Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] bump pymare version to fix z values #904

Merged
merged 2 commits into from
Sep 11, 2024
Merged

[FIX] bump pymare version to fix z values #904

merged 2 commits into from
Sep 11, 2024

Conversation

jdkent
Copy link
Member

@jdkent jdkent commented Sep 11, 2024 •
edited by sourcery-ai bot
Loading

Closes # .

Changes proposed in this pull request:

Summary by Sourcery

Bump the pymare package version from 0.0.7 to 0.0.8 in the setup configuration to fix issues related to z values.

Bug Fixes:

  • Update pymare dependency version to 0.0.8 to address issues with z values.

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Sep 11, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request updates the pymare dependency version from 0.0.7 to 0.0.8 in the setup.cfg file. The change is made to fix z values, as indicated in the pull request title.

File-Level Changes

Change Details Files
Bump pymare version from 0.0.7 to 0.0.8
  • Update pymare version in install_requires section
  • Update pymare version in minimum dependencies section
 setup.cfg
Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jdkent - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you please provide more information in the pull request description? Specifically, it would be helpful to explain the z value issue you're addressing and how this pymare version bump resolves it. This context will be valuable for future reference and for other contributors.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@JulioAPeraza JulioAPeraza mentioned this pull request Sep 11, 2024
Closed
@JulioAPeraza
Copy link
Collaborator

The change here: https://github.com/neurostuff/NiMARE/pull/903/files#diff-28db297ccb8f266a46d62412ac9cb9efde23ed3a1ea07a7db12313dc50b7e5b1 should fix the issues in the example gallery.
For the GitHub action, we only need to upgrade upload-artifact and download-artifact from v2 to v4.

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (5fb7ae1) to head (f7549b1).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #904   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files          48       48           
  Lines        6382     6382           
=======================================
  Hits         5631     5631           
  Misses        751      751

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdkent
Copy link
Member Author

jdkent commented Sep 11, 2024

looks good to me!
https://nimare--904.org.readthedocs.build/en/904/auto_examples/02_meta-analyses/02_plot_ibma.html#sphx-glr-auto-examples-02-meta-analyses-02-plot-ibma-py

@jdkent jdkent merged commit 78b79f4 into main Sep 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdkent @JulioAPeraza